| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: "long" type is not appropriate for counting tuples |
| Date: | 2019-07-04 15:02:59 |
| Message-ID: | 680a62ca-4203-4f13-bb15-cbc03040a5b6@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-07-02 22:56, Tom Lane wrote:
> I took a look through these and see nothing objectionable. There are
> probably more places that can be improved, but we need not insist on
> getting every such place in one go.
>
> Per Robert's position that variables ought to have well-defined widths,
> there might be something to be said for not touching the variable
> declarations that you changed from int64 to long long, and instead
> casting them to long long in the sprintf calls. But I'm not really
> convinced that that's better than what you've done.
>
> Marked CF entry as ready-for-committer.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-07-04 15:12:26 | Re: [PATCH] Implement uuid_version() |
| Previous Message | Tomas Vondra | 2019-07-04 14:46:11 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |