Re: Extensions, this time with a patch

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, David E(dot) Wheeler <david(at)kineticode(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extensions, this time with a patch
Date: 2010-10-22 20:02:22
Message-ID: 1287776990-sup-5765@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Dimitri Fontaine's message of vie oct 22 16:21:14 -0300 2010:

> So I think it's a good compromise, and as it's superuser-only I would
> think it's acceptable as-is. Apparently it's not, which ain't the end of
> the world but an unexpected surprise for me. And when I don't
> understand, I tend to insist until I do or until I resign, whichever
> comes first, but you would know that by now :)

Yeah, well, this is just my personal opinion. Others are welcome to
chime in.

> I'll go rework the patch sometime later to drop the name from the
> control file, but that also means fixing several contrib modules by
> changing their file names, operation for which the project has no policy
> yet as far as I understand (we used CVS before).

Change what file names? You lost me there. I thought the extension
name was going to be equal to the control file name, and said control
file doesn't exist yet, so you don't need to rename any existant file.
Am I confusing something?

That said, I don't think there's any reason now to stop a committer from
renaming files (as long as this has been previously discussed and agreed
to, just like any other commit).

> Superuser only. To manage extensions, nothing to do with live load or
> user queries. But if you say performance is important here and 3ms to
> display all available extensions sucks, so be it.

To be honest I'm not all that concerned with raw performance here. I
just think that scanning a directory is a strange way for the search to
behave.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-10-22 20:07:10 Re: Extensions, this time with a patch
Previous Message Robert Haas 2010-10-22 19:54:01 Re: Integer input functions for date and timestamp