Re: Extensions, this time with a patch

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, David E(dot) Wheeler <david(at)kineticode(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extensions, this time with a patch
Date: 2010-10-25 13:37:22
Message-ID: 1288013658-sup-9099@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Alvaro Herrera's message of vie oct 22 17:02:22 -0300 2010:
> Excerpts from Dimitri Fontaine's message of vie oct 22 16:21:14 -0300 2010:

> > I'll go rework the patch sometime later to drop the name from the
> > control file, but that also means fixing several contrib modules by
> > changing their file names, operation for which the project has no policy
> > yet as far as I understand (we used CVS before).
>
> Change what file names? You lost me there. I thought the extension
> name was going to be equal to the control file name, and said control
> file doesn't exist yet, so you don't need to rename any existant file.
> Am I confusing something?

Hmm, after reading the latest blog post, it seems that the patch
requires that the control file is equal to the .sql install script. Is
this the case? I don't see a reason for this requirement; why not
simply have a line for the install script in the control file? That
way, you don't need to rename the .sql files.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-10-25 14:21:49 Re: Range Types, discrete and/or continuous
Previous Message Robert Haas 2010-10-25 13:33:58 Re: O_DSYNC broken on MacOS X?