| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jacob Champion <jchampion(at)timescale(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Mark Guertin <markguertin(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files |
| Date: | 2023-07-06 23:05:20 |
| Message-ID: | 1264127.1688684720@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Jacob Champion <jchampion(at)timescale(dot)com> writes:
> My two cents: backpatching an exception for .DS_Store seems good, but
> creating an exclusion for all hidden files feels like a surprising
> change for stable branches.
On the whole, I think I'd vote for blocking .DS_Store only, even
in HEAD. (IIRC, I thought differently to start with, but today
I'm feeling conservative about it.) If there are other special
file names on other platforms, we could add some more targeted
exceptions; but dropping all hidden files seems more likely to
break things than be helpful.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-07-07 07:02:59 | Re: BUG #17540: Prepared statement: PG switches to a generic query plan which is consistently much slower |
| Previous Message | Jacob Champion | 2023-07-06 21:14:59 | Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files |