| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jacob Champion <jchampion(at)timescale(dot)com>, Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Mark Guertin <markguertin(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files |
| Date: | 2023-07-07 07:23:38 |
| Message-ID: | 26E0612E-B3AA-45C6-BC1E-B1575E0B83B0@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
> On 7 Jul 2023, at 01:05, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Jacob Champion <jchampion(at)timescale(dot)com> writes:
>> My two cents: backpatching an exception for .DS_Store seems good, but
>> creating an exclusion for all hidden files feels like a surprising
>> change for stable branches.
>
> On the whole, I think I'd vote for blocking .DS_Store only, even
> in HEAD. (IIRC, I thought differently to start with, but today
> I'm feeling conservative about it.) If there are other special
> file names on other platforms, we could add some more targeted
> exceptions; but dropping all hidden files seems more likely to
> break things than be helpful.
I think the case for skipping all hidden files is that it would offer more
consistency with other serverside filesystem reads are performed. After
.DS_Store I would think that editor swapfiles would be other likely culprit of
hidden-but-not-belonging files.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 蔡梦娟 (玊于) | 2023-07-07 09:48:39 | 回复：The same 2PC data maybe recovered twice |
| Previous Message | Richard Guo | 2023-07-07 07:02:59 | Re: BUG #17540: Prepared statement: PG switches to a generic query plan which is consistently much slower |