| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: pg_upgrade: Check version of target cluster binaries |
| Date: | 2021-03-03 22:04:41 |
| Message-ID: | 1249994.1614809081@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 3/3/21 3:28 PM, Tom Lane wrote:
>> Crake says this patch broke its cross-version upgrade tests:
> The log says:
> check for
> "/home/andrew/bf/root/upgrade.crake/REL9_2_STABLE/inst/bin/postgres"
> failed: incorrect version: found "postgres (PostgreSQL) 9.2.24",
> expected "postgres (PostgreSQL) 14devel"
> But that makes no sense at all. Looks like we're confusing the source and the target.
On looking closer, I think the patch is just several bricks shy of a
load. It's applying validate_exec (which insists on a match to its
own version number) to *both* the source and target binaries. It
must not check the source that way.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-03-04 00:06:36 | Re: pgsql: pg_upgrade: Check version of target cluster binaries |
| Previous Message | Andrew Dunstan | 2021-03-03 21:58:09 | Re: pgsql: pg_upgrade: Check version of target cluster binaries |