Re: pgsql: pg_upgrade: Check version of target cluster binaries

> On 3 Mar 2021, at 23:04, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 3/3/21 3:28 PM, Tom Lane wrote:
>>> Crake says this patch broke its cross-version upgrade tests:
>
>> The log says:
>> check for
>> "/home/andrew/bf/root/upgrade.crake/REL9_2_STABLE/inst/bin/postgres"
>> failed: incorrect version: found "postgres (PostgreSQL) 9.2.24",
>> expected "postgres (PostgreSQL) 14devel"
>> But that makes no sense at all. Looks like we're confusing the source and the target.
>
> On looking closer, I think the patch is just several bricks shy of a
> load. It's applying validate_exec (which insists on a match to its
> own version number) to *both* the source and target binaries. It
> must not check the source that way.

It's much to late to focus here at the moment, I will take a look in the
morning unless beaten to it.

--
Daniel Gustafsson https://vmware.com/