Re: pgsql: pg_upgrade: Check version of target cluster binaries

On 3/3/21 3:28 PM, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> pg_upgrade: Check version of target cluster binaries
> Crake says this patch broke its cross-version upgrade tests:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2021-03-03%2009%3A02%3A31
>
> where the important bit is
>
> check for "/home/andrew/bf/root/upgrade.crake/REL9_2_STABLE/inst/bin/postgres" failed: incorrect version: found "postgres (PostgreSQL) 9.2.24", expected "postgres (PostgreSQL) 14devel"
>
> It's not at all clear from here whether that's a bug in the patch
> or in the buildfarm's test harness.
>
>

This has worked for years ... here's the latest code:
<https://github.com/PGBuildFarm/client-code/blob/master/PGBuild/Modules/TestUpgradeXversion.pm>
The invocation of pg_upgrade is at line 560.

The log says:

check for
"/home/andrew/bf/root/upgrade.crake/REL9_2_STABLE/inst/bin/postgres"
failed: incorrect version: found "postgres (PostgreSQL) 9.2.24",
expected "postgres (PostgreSQL) 14devel"

But that makes no sense at all. Looks like we're confusing the source and the target.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com