Re: [DEPARSE] AT TIME ZONE and similar as a function in FROM do not read back

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: assam258(at)gmail(dot)com
Cc: Prashant Kumar <crprashant(at)hotmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [DEPARSE] AT TIME ZONE and similar as a function in FROM do not read back
Date: 2026-10-27 21:30:34
Message-ID: 1239368.1793136634@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Henson Choi <assam258(at)gmail(dot)com> writes:
> The code in 0002 is unchanged from v1. 0001 has the two new
> columns, with the output before the fix, and 0002 updates their
> output along with the others.

Pushed with some editorialization. I did not see the need to
complicate the API spec for looks_like_function(): it's defined
to say whether the construct will parse as func_expr_windowless,
and that's what it should do. I don't think the cases where
this results in extra parentheses are common enough to be a
big deal, especially since there seem to be none in our
regression tests.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-10-27 21:39:52 Re: ICU fixed digit reordering bug
Previous Message Sami Imseih 2026-10-27 21:18:36 [PATCH] pgstat: Add helper to drop entries from a stats kind's hash