Re: [DEPARSE] AT TIME ZONE and similar as a function in FROM do not read back

Hi Prashant,

> One suggestion: the tests added to tt20v cover the timestamp and
> timestamptz forms, but not the timetz form of AT TIME ZONE, which
> is broken in the same way and fixed by the same list. Adding that
> one case would pin the timetz entries of the list against
> regressions.

Done in v2, attached. tt20v now also has

cast(current_time at time zone 'UTC' as timetz) as atzt

which goes through F_TIMEZONE_TEXT_TIMETZ.

While at it, I added one more column for ROWS FROM. The commit
message says the fix covers a function alone in FROM or in ROWS
FROM, but v1 only tested the first. ROWS FROM prints each of its
functions through the same get_rule_expr_funccall(), so it now gets
the CAST back the same way:

rows from(cast('foo' is normalized as boolean), now()) as rf(rfa, rfb)

before:
ROWS FROM(('foo'::text IS NORMALIZED), now()) rf(rfa, rfb)
after:
ROWS FROM(CAST(('foo'::text IS NORMALIZED) AS boolean), now()) rf(rfa,
rfb)

It has two functions because ROWS FROM() is printed only then; a
single function is printed alone.

The code in 0002 is unchanged from v1. 0001 has the two new
columns, with the output before the fix, and 0002 updates their
output along with the others.

Regards,
Henson