| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Typos in the code and README |
| Date: | 2026-01-04 23:32:14 |
| Message-ID: | 1185975.1767569534@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Thu, Jan 01, 2026 at 10:00:00AM +0200, Alexander Lakhin wrote:
>> replace_s(..., int * adjustment) -> replace_s(..., int * adjptr)
> Updating this one contradicts with the upstream sources, see
> b464e51ab32f that has done the opposite switch.
It looks like upstream has fixed the problem -- not by making the
two instances match, but by removing the parameter altogether
(see their recent commit 16edd5abb9ce7386e9208b998cd43524480cb801).
Maybe it's time for another sync with upstream? But if we don't
feel like doing that right now, I think Alexander's proposed patch
is okay. It won't make the next sync any harder.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-01-04 23:42:52 | Re: intarray: fix an edge case int32 overflow bug |
| Previous Message | David Rowley | 2026-01-04 23:25:35 | Re: Docs pg_restore: Shouldn't there be a note about -n ? |