| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Lakhin <exclusion(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Typos in the code and README |
| Date: | 2026-01-05 21:39:42 |
| Message-ID: | ld2iurl7kzexwydxmdfhdgarpa7xxsfrgvggqhbblt4rvt3h6t@bxsk6oz5x7cc |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2026-01-04 18:32:14 -0500, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
> > On Thu, Jan 01, 2026 at 10:00:00AM +0200, Alexander Lakhin wrote:
> >> replace_s(..., int * adjustment) -> replace_s(..., int * adjptr)
>
> > Updating this one contradicts with the upstream sources, see
> > b464e51ab32f that has done the opposite switch.
>
> It looks like upstream has fixed the problem -- not by making the
> two instances match, but by removing the parameter altogether
> (see their recent commit 16edd5abb9ce7386e9208b998cd43524480cb801).
>
> Maybe it's time for another sync with upstream? But if we don't
> feel like doing that right now, I think Alexander's proposed patch
> is okay. It won't make the next sync any harder.
Your recent commit unfortunately doesn't build with meson, due to headers now
not just residing in src/include/snowball/ but also
src/include/snowball/libstemmer/.
The fix is trivial - happy to push it if you want?
Greetings,
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-01-05 21:43:02 | Re: Typos in the code and README |
| Previous Message | Tomas Vondra | 2026-01-05 21:35:45 | Re: failed NUMA pages inquiry status: Operation not permitted |