| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Mark Wong <markw(at)osdl(dot)org>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: WIP: splitting BLCKSZ |
| Date: | 2006-04-04 19:18:24 |
| Message-ID: | 1144178304.13549.554.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Tue, 2006-04-04 at 17:33 +0100, Simon Riggs wrote:
> On Tue, 2006-04-04 at 11:13 -0400, Tom Lane wrote:
> > Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > > I see you've changed the control file back from XLOG_BLCKSZ to BLCKSZ; I
> > > wasn't sure which one of those to choose.
> >
> > Hm. The entire point of having a BLCKSZ-sized control file is to have
> > it *not* change in size across format revisions (see the comments) ...
> > which I suppose means that we really ought to have a hard-wired separate
> > constant, rather than depending on something that someone might want to
> > twiddle.
An additional patch enclosed that adds xlog blcksz onto the xlog long
header at the start of each xlog file, so we can cross-check between
file and system, as we do with xlog seg size.
(This is an *additional* patch, not a replacement one).
Best Regards, Simon Riggs
| Attachment | Content-Type | Size |
|---|---|---|
| xlog_lhdr.patch | text/x-patch | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-04-04 19:26:12 | Re: WIP: splitting BLCKSZ |
| Previous Message | Simon Riggs | 2006-04-04 16:33:28 | Re: WIP: splitting BLCKSZ |