From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Mark Wong <markw(at)osdl(dot)org>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: WIP: splitting BLCKSZ |
Date: | 2006-04-04 16:33:28 |
Message-ID: | 1144168408.13549.506.camel@localhost.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
On Tue, 2006-04-04 at 11:13 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > I see you've changed the control file back from XLOG_BLCKSZ to BLCKSZ; I
> > wasn't sure which one of those to choose.
>
> Hm. The entire point of having a BLCKSZ-sized control file is to have
> it *not* change in size across format revisions (see the comments) ...
> which I suppose means that we really ought to have a hard-wired separate
> constant, rather than depending on something that someone might want to
> twiddle.
Patch enclosed.
Tests with make check and this sequence of actions works fine also...
initdb b512
pg_controldata b512
pg_resetxlog b512
pg_controldata b512
Best Regards, Simon Riggs
Attachment | Content-Type | Size |
---|---|---|
xlog_control_blcksz.patch | text/x-patch | 6.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2006-04-04 19:18:24 | Re: WIP: splitting BLCKSZ |
Previous Message | Tom Lane | 2006-04-04 15:13:38 | Re: WIP: splitting BLCKSZ |