Re: WIP: splitting BLCKSZ

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Mark Wong <markw(at)osdl(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: WIP: splitting BLCKSZ
Date: 2006-04-04 19:26:12
Message-ID: 13519.1144178772@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> An additional patch enclosed that adds xlog blcksz onto the xlog long
> header at the start of each xlog file, so we can cross-check between
> file and system, as we do with xlog seg size.

That would require an xlog format change (XLOG_PAGE_MAGIC bump). Might
be worth it anyway to avoid confusion in PITR log-shipping situations.
I thought about it yesterday, and concluded it wasn't really worth the
trouble, but am willing to reconsider.

Note you forgot pg_resetxlog again .-)

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-04-04 22:41:35 Re: WIP: splitting BLCKSZ
Previous Message Simon Riggs 2006-04-04 19:18:24 Re: WIP: splitting BLCKSZ