Re: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v
Date: 2011-02-25 22:31:13
Message-ID: 1137.1298673073@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Fix pageinspect's heap_page_item to return infomasks as 32 bit values
> HeapTupleHeader's t_infomask and t_infomask2 are defined as 16-bit
> unsigned integers, so when the 16th bit was set, heap_page_item was
> returning them as negative values, which was ugly.

> The change to pageinspect--unpackaged--1.0.sql allows a module upgraded
> from 9.0 to be cleanly updated from the previous definition.

I think you forgot to commit the matching change in pageinspect--1.0.sql ?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2011-02-25 22:40:37 pgsql: Update pageinspect--1.0.sql to match the upgrade script
Previous Message Alvaro Herrera 2011-02-25 22:08:26 pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v