| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v |
| Date: | 2011-02-25 22:41:02 |
| Message-ID: | 1298673635-sup-7604@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Excerpts from Tom Lane's message of vie feb 25 19:31:13 -0300 2011:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Fix pageinspect's heap_page_item to return infomasks as 32 bit values
> > HeapTupleHeader's t_infomask and t_infomask2 are defined as 16-bit
> > unsigned integers, so when the 16th bit was set, heap_page_item was
> > returning them as negative values, which was ugly.
>
> > The change to pageinspect--unpackaged--1.0.sql allows a module upgraded
> > from 9.0 to be cleanly updated from the previous definition.
>
> I think you forgot to commit the matching change in pageinspect--1.0.sql ?
Oops, yeah, thanks.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-02-25 23:58:26 | pgsql: Support data-modifying commands (INSERT/UPDATE/DELETE) in WITH. |
| Previous Message | Alvaro Herrera | 2011-02-25 22:40:37 | pgsql: Update pageinspect--1.0.sql to match the upgrade script |