pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v
Date: 2011-02-25 22:08:26
Message-ID: E1Pt5pq-0007QV-IF@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pageinspect's heap_page_item to return infomasks as 32 bit values

HeapTupleHeader's t_infomask and t_infomask2 are defined as 16-bit
unsigned integers, so when the 16th bit was set, heap_page_item was
returning them as negative values, which was ugly.

The change to pageinspect--unpackaged--1.0.sql allows a module upgraded
from 9.0 to be cleanly updated from the previous definition.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/a338d654614f897ccb58eaa8a6171abdb7dc8dff

Modified Files
--------------
contrib/pageinspect/heapfuncs.c | 4 ++--
.../pageinspect/pageinspect--unpackaged--1.0.sql | 20 +++++++++++++++++++-
2 files changed, 21 insertions(+), 3 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-02-25 22:31:13 Re: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v
Previous Message Robert Haas 2011-02-25 00:02:08 pgsql: Named restore point improvements.