From: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
---|---|
To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Przemysław Sztoch <przemyslaw(at)sztoch(dot)pl> |
Subject: | Re: encode/decode support for base64url |
Date: | 2025-07-10 03:25:29 |
Message-ID: | 0F9CC1F5-2CEA-4CA1-9711-43C88E32F796@gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thanks for the review Aleksander,
> On 9 Jul 2025, at 10:45 PM, Aleksander Alekseev <aleksander(at)tigerdata(dot)com> wrote:
>
> Hi Florents,
>
> Thanks for the update!
>
>> here's a v4 patch set
>>
>> - Extracted pg_base64_{en,de}_internal with an additional bool url param, to be used by other functions
>> - Added a few more test cases
>>
>> Cary mentioned above
>>
>>> In addition, you may also want to add the C versions of base64rul encode
>> and decode functions to "src/common/base64.c" as new API calls
>>
>> Haven't done that, but I could;
>> Although I think it'd probably be best to do it in a separate patch.
>
> I reviewed and tested v4. To me it looks as good as it will get.
> Personally I would change a few minor things here and there and
> probably merge all three patches into a single commit. This however is
> up to the committer to decide.
Attaching a single-file patch
Attachment | Content-Type | Size |
---|---|---|
v4-base64url.patch | application/octet-stream | 23.9 KB |
unknown_filename | text/plain | 46 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2025-07-10 03:31:22 | Re: Fix comment in btree_gist--1.8--1.9.sql |
Previous Message | Amit Kapila | 2025-07-10 03:19:07 | Re: Using failover slots for PG-non_PG logical replication |