| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Przemysław Sztoch <przemyslaw(at)sztoch(dot)pl> |
| Subject: | Re: encode/decode support for base64url |
| Date: | 2025-07-09 14:45:42 |
| Message-ID: | CAJ7c6TOG4SuVGd2L17A7qjLx0ReqoXs9DZVAeHtQtytkk-b7=g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Florents,
Thanks for the update!
> here's a v4 patch set
>
> - Extracted pg_base64_{en,de}_internal with an additional bool url param, to be used by other functions
> - Added a few more test cases
>
> Cary mentioned above
>
> > In addition, you may also want to add the C versions of base64rul encode
> and decode functions to "src/common/base64.c" as new API calls
>
> Haven't done that, but I could;
> Although I think it'd probably be best to do it in a separate patch.
I reviewed and tested v4. To me it looks as good as it will get.
Personally I would change a few minor things here and there and
probably merge all three patches into a single commit. This however is
up to the committer to decide.
Changing the CF entry status to "RfC".
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hannu Krosing | 2025-07-09 14:52:16 | Re: Horribly slow pg_upgrade performance with many Large Objects |
| Previous Message | Frédéric Yhuel | 2025-07-09 14:30:04 | Re: [doc] minor fix for CREATE INDEX CONCURRENTLY |