| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com> |
| Subject: | Re: Fix outdated comments for IndexInfo |
| Date: | 2025-07-02 07:57:50 |
| Message-ID: | 06a0b50c-dee7-46f5-8449-087e767d5849@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01.05.25 15:47, Japin Li wrote:
> On Thu, 01 May 2025 at 12:13, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> On 30.04.25 17:48, Japin Li wrote:
>>> While working on [1], I found outdated comments in IndexInfo.
>>> The attached patch corrects them.
>>> [1]
>>> https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F1E4%40logansw.com
>>
>> Maybe these per-column comments should be moved inline, similar to,
>> for example, ResultRelInfo later in the file. That would make
>> maintaining them easier.
>
> Thank you for the review. The v2 patch set is attached.
>
> v2-0001 remains unchanged; v2-0002 has been modified according to your feedback.
I have committed your patch 0001 and backpatched it appropriately, so
that each branch should now have approximately correct comments. And
then I have applied your 0002 to master. Thanks.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2025-07-02 08:06:34 | Re: Fix inconsistency in the pg_buffercache documentation |
| Previous Message | Daniel Gustafsson | 2025-07-02 07:55:52 | Re: Fix inconsistency in the pg_buffercache documentation |