| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com> |
| Subject: | Re: Fix outdated comments for IndexInfo |
| Date: | 2025-05-01 13:47:14 |
| Message-ID: | ME0P300MB0445D523EA4AB5B6C27B633DB6822@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Peter and Richard
On Thu, 01 May 2025 at 12:13, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> On 30.04.25 17:48, Japin Li wrote:
>> While working on [1], I found outdated comments in IndexInfo.
>> The attached patch corrects them.
>> [1]
>> https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F1E4%40logansw.com
>
> Maybe these per-column comments should be moved inline, similar to,
> for example, ResultRelInfo later in the file. That would make
> maintaining them easier.
Thank you for the review. The v2 patch set is attached.
v2-0001 remains unchanged; v2-0002 has been modified according to your feedback.
--
Regrads,
Japin Li
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-outdated-comments-for-IndexInfo.patch | text/x-diff | 1.4 KB |
| v2-0002-Use-per-column-comments-for-IndexInfo.patch | text/x-diff | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2025-05-01 13:47:46 | Re: Should shared_preload_libraries be loaded during binary upgrade? |
| Previous Message | Andrei Lepikhov | 2025-05-01 13:37:52 | Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost adjustment |