Re: [Proposal] Global temporary tables

From: 曾文旌 <wenjing(dot)zwj(at)alibaba-inc(dot)com>
To: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
Cc: Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, "蔡松露(子嘉)" <zijia(at)taobao(dot)com>, "Cai, Le" <le(dot)cai(at)alibaba-inc(dot)com>, "萧少聪(铁庵)" <shaocong(dot)xsc(at)alibaba-inc(dot)com>
Subject: Re: [Proposal] Global temporary tables
Date: 2020-03-31 04:16:31
Message-ID: 06844F6A-0BD2-438E-95E5-E76E4CB5CA57@alibaba-inc.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> 2020年3月27日 下午5:21,tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> 写道:
>
> On 3/27/20 10:55 AM, 曾文旌 wrote:
>>> Hi Wenjing,
>>> This patch(gtt_v21_pg13.patch) is not applicable on PG HEAD, I hope you have prepared the patch on top of some previous commit.
>>> Could you please rebase the patch which we can apply on HEAD ?
>> Yes, It looks like the built-in functions are in conflict with new code.
>>
>>
> This error message looks wrong to me-
>
> postgres=# reindex table concurrently t ;
> ERROR: cannot create indexes on global temporary tables using concurrent mode
> postgres=#
>
> Better message would be-
>
> ERROR: cannot reindex global temporary tables concurrently
>
I found that the local temp table automatically disables concurrency mode.
so, I made some improvements, The reindex GTT behaves the same as the local temp table.

Wenjing

>
> --
> regards,tushar
> EnterpriseDB https://www.enterprisedb.com/ <https://www.enterprisedb.com/>
> The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2020-03-31 04:30:19 Re: Internal key management system
Previous Message 曾文旌 2020-03-31 04:11:58 Re: [Proposal] Global temporary tables