Re: [Proposal] Global temporary tables

From: Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com>
To: 曾文旌 <wenjing(dot)zwj(at)alibaba-inc(dot)com>
Cc: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, 蔡松露(子嘉) <zijia(at)taobao(dot)com>, "Cai, Le" <le(dot)cai(at)alibaba-inc(dot)com>, 萧少聪(铁庵) <shaocong(dot)xsc(at)alibaba-inc(dot)com>
Subject: Re: [Proposal] Global temporary tables
Date: 2020-03-31 13:59:15
Message-ID: CANEvxPoKNoddQ6UYOgXkGSZuc30KVZODySJu1E=a8hs1P7PPgA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Wenjing,
Thanks for the new patch.
I saw with the patch(gtt_v23.patch), we are supporting the new concept
"global temporary sequence"(i.e. session-specific sequence), is this
intentional?

postgres=# create *global temporary sequence* gt_seq;
CREATE SEQUENCE
postgres=# create sequence seq;
CREATE SEQUENCE
postgres=# \d+
List of relations
Schema | Name | Type | Owner | Persistence | Size |
Description
--------+--------+----------+-------+-------------+------------+-------------
*public | gt_seq | sequence | edb | session | 8192 bytes |*
public | seq | sequence | edb | permanent | 8192 bytes |
(2 rows)

postgres=# select *nextval('gt_seq')*, nextval('seq');
nextval | nextval
---------+---------
* 1* | 1
(1 row)

postgres=# select nextval('gt_seq'), nextval('seq');
nextval | nextval
---------+---------
*2* | 2
(1 row)

-- Exit and re-connect to psql prompt:
postgres=# \q
[edb(at)localhost bin]$ ./psql postgres
psql (13devel)
Type "help" for help.

postgres=# select nextval('gt_seq'), nextval('seq');
nextval | nextval
---------+---------
* 1* | 3
(1 row)

postgres=# select nextval('gt_seq'), nextval('seq');
nextval | nextval
---------+---------
*2 *| 4
(1 row)

On Tue, Mar 31, 2020 at 9:46 AM 曾文旌 <wenjing(dot)zwj(at)alibaba-inc(dot)com> wrote:

>
>
> 2020年3月27日 下午5:21,tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> 写道:
>
> On 3/27/20 10:55 AM, 曾文旌 wrote:
>
> Hi Wenjing,
> This patch(gtt_v21_pg13.patch) is not applicable on PG HEAD, I hope you
> have prepared the patch on top of some previous commit.
> Could you please rebase the patch which we can apply on HEAD ?
>
> Yes, It looks like the built-in functions are in conflict with new code.
>
>
> This error message looks wrong to me-
>
> postgres=# reindex table concurrently t ;
> ERROR: cannot create indexes on global temporary tables using concurrent
> mode
> postgres=#
>
> Better message would be-
>
> ERROR: cannot reindex global temporary tables concurrently
>
> I found that the local temp table automatically disables concurrency mode.
> so, I made some improvements, The reindex GTT behaves the same as the
> local temp table.
>
>
> Wenjing
>
>
>
>
> --
> regards,tushar
> EnterpriseDB https://www.enterprisedb.com/
> The Enterprise PostgreSQL Company
>
>
>

--

With Regards,
Prabhat Kumar Sahu
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2020-03-31 14:00:42 Re: Random set of typos spotted
Previous Message Julien Rouhaud 2020-03-31 13:51:58 Re: WAL usage calculation patch