Re: cleanup temporary files after crash

On Tue, Mar 9, 2021, at 9:31 AM, Michael Paquier wrote:
> On Tue, Mar 09, 2021 at 02:28:43AM +0100, Tomas Vondra wrote:
> > Let's move this patch forward. Based on the responses, I agree the
> > default behavior should be to remove the temp files, and I think we
> > should have the GUC (on the off chance that someone wants to preserve
> > the temporary files for debugging or whatever other reason).
>
> Thanks for taking care of this. I am having some second-thoughts
> about changing this behavior by default, still that's much more useful
> this way.
>
> > I propose to rename the GUC to remove_temp_files_after_crash, I think
> > "remove" is a bit clearer than "cleanup". I've also reworded the sgml
> > docs a little bit.
>
> "remove" sounds fine to me.
+1.

> > Attached is a patch with those changes. Barring objections, I'll get
> > this committed in the next couple days.
>
> + When set to on, <productname>PostgreSQL</productname> will automatically
> Nit: using a <literal> markup for the "on" value.
>
> +#remove_temp_files_after_crash = on # remove temporary files after
> +# # backend crash?
> The indentation of the second line is incorrect here (Incorrect number
> of spaces in tabs perhaps?), and there is no need for the '#' at the
> beginning of the line.
> --
> Michael
That was my fault. Editor automatically added #.

I'm not sure Tomas will include the tests. If so. the terminology should be adjusted too.

+++ b/src/test/recovery/t/022_crash_temp_files.pl
@@ -0,0 +1,194 @@
+#
+# Test cleanup of temporary files after a crash.

s/cleanup/remove/

--
Euler Taveira
EDB https://www.enterprisedb.com/