| From: | David Steele <david(at)pgbackrest(dot)org> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Regression in statement locations |
| Date: | 2025-05-20 14:04:20 |
| Message-ID: | 0546d531-50eb-4ffc-b046-987cae4ab4f6@pgbackrest.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/20/25 07:34, Sami Imseih wrote:
> Tested the patch and it looks good to me.
>
> Not that I thought it would fail, but I also confirmed the pgaudit case
> works as expected.
I also tested and everything looks good with the patch.
I did a careful examination of the remaining diffs (there are quite a
few) and in every case I consider them to be beneficial, i.e. they make
the output more targeted and readable.
I did not do a real code review, but I did notice that the test table
column is called weird_name as in our tests. I would argue that since it
is missing the quotes and space it is not really all that weird and
should maybe get a normal name so developers in the future don't wonder
what is weird about it.
Thank you for this improvement and the quick fix!
Regards,
-David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2025-05-20 14:15:54 | Re: PG 18 release notes draft committed |
| Previous Message | Bruce Momjian | 2025-05-20 13:52:17 | Re: PG 18 release notes draft committed |