Re: PG 18 release notes draft committed

On Tue, May 20, 2025 at 03:46:44PM +0300, Nazir Bilal Yavuz wrote:
> Hi,
>
> Thanks for working on this!
>
> On Fri, 2 May 2025 at 05:44, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >
> > I will continue improving it until beta 1, and until the final release.
> > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-)
>
> +<listitem>
> +<para>
> +Add server variable file_copy_method to control the file copying
> method (Nazir Bilal Yavuz)
> +<ulink url="&commit_baseurl;f78ca6f3e">&sect;</ulink>
> +</para>

Uh, the commit is:

commit f78ca6f3ebb
Author: Thomas Munro <tmunro(at)postgresql(dot)org>
Date: Tue Apr 8 20:52:47 2025 +1200

Introduce file_copy_method setting.

It can be set to either COPY (the default) or CLONE if the system
supports it. CLONE causes callers of copydir(), currently CREATE
DATABASE ... STRATEGY=FILE_COPY and ALTER DATABASE ... SET TABLESPACE =
..., to use copy_file_range (Linux, FreeBSD) or copyfile (macOS) to copy
files instead of a read-write loop over the contents.

CLONE gives the kernel the opportunity to share block ranges on
copy-on-write file systems and push copying down to storage on others,
depending on configuration. On some systems CLONE can be used to clone
large databases quickly with CREATE DATABASE ... TEMPLATE=source
STRATEGY=FILE_COPY.

Other operating systems could be supported; patches welcome.

Co-authored-by: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Reviewed-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Reviewed-by: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Discussion: https://postgr.es/m/CA%2BhUKGLM%2Bt%2BSwBU-cHeMUXJCOgBxSHLGZutV5zCwY4qrCcE02w%40mail.gmail.com

As of the date of the commit, "Co-authored-by:" is listed as:

https://wiki.postgresql.org/wiki/Commit_Message_Guidance

"Co-authored-by:" is used by committers when they want to give full credit
to the named individuals, but also indicate that they made significant
changes.

> A minor fix; I co-authored this with Thomas Munro, he is the actual author.

Uh, does this mean I should add Thomas Munro before or after your name,
or remove your name and list only Thomas Munro?

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.