| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: broken regress tests on fedora 36 |
| Date: | 2022-06-07 14:54:07 |
| Message-ID: | 044dd43b-f887-da7d-c7ca-423500caacf0@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-06-07 Tu 08:56, Michael Paquier wrote:
> On Tue, Jun 07, 2022 at 10:52:45AM +0200, Pavel Stehule wrote:
>> # Failed test '\timing with query error: timing output appears'
>> # at t/001_basic.pl line 95.
>> # 'Time: 0,293 ms'
>> # doesn't match '(?^m:^Time: \d+\.\d\d\d ms)'
>> # Looks like you failed 2 tests of 58.
> Fun. The difference is in the separator: dot vs comma. This should
> fail with French the same way. Perhaps it would fail differently in
> other languages? There is no need to be that precise with the regex
> IMO, so I would just cut the regex with the number, checking only the
> unit at the end.
or just replace '\.' with '[.,]'
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-06-07 15:12:43 | Re: effective_io_concurrency and NVMe devices |
| Previous Message | Jonathan S. Katz | 2022-06-07 14:52:38 | Re: How about a psql backslash command to show GUCs? |