Re: broken regress tests on fedora 36

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: broken regress tests on fedora 36
Date: 2022-06-07 12:56:02
Message-ID: Yp9K4o31JHaLTXnZ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 07, 2022 at 10:52:45AM +0200, Pavel Stehule wrote:
> # Failed test '\timing with query error: timing output appears'
> # at t/001_basic.pl line 95.
> # 'Time: 0,293 ms'
> # doesn't match '(?^m:^Time: \d+\.\d\d\d ms)'
> # Looks like you failed 2 tests of 58.

Fun. The difference is in the separator: dot vs comma. This should
fail with French the same way. Perhaps it would fail differently in
other languages? There is no need to be that precise with the regex
IMO, so I would just cut the regex with the number, checking only the
unit at the end.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ian Lawrence Barwick 2022-06-07 13:08:21 Re: docs: mention "pg_read_all_stats" in "track_activities" description
Previous Message Amit Kapila 2022-06-07 12:32:13 Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns