Re: broken regress tests on fedora 36

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: broken regress tests on fedora 36
Date: 2022-06-07 23:59:10
Message-ID: Yp/mTjAVqhxBT5uh@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 07, 2022 at 10:54:07AM -0400, Andrew Dunstan wrote:
> On 2022-06-07 Tu 08:56, Michael Paquier wrote:
>> On Tue, Jun 07, 2022 at 10:52:45AM +0200, Pavel Stehule wrote:
>>> # Failed test '\timing with query error: timing output appears'
>>> # at t/001_basic.pl line 95.
>>> # 'Time: 0,293 ms'
>>> # doesn't match '(?^m:^Time: \d+\.\d\d\d ms)'
>>> # Looks like you failed 2 tests of 58.
>> Fun. The difference is in the separator: dot vs comma. This should
>> fail with French the same way. Perhaps it would fail differently in
>> other languages? There is no need to be that precise with the regex
>> IMO, so I would just cut the regex with the number, checking only the
>> unit at the end.
>
> or just replace '\.' with '[.,]'

I was wondering about other separators actually:
https://en.wikipedia.org/wiki/Decimal_separator#Usage_worldwide

These two should be enough, though. So changing only that sounds fine
by me.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chinmay Kanchi 2022-06-08 00:00:45 Re: An inverted index using roaring bitmaps
Previous Message Tom Lane 2022-06-07 23:58:25 Re: How about a psql backslash command to show GUCs?