Re: run pgindent in CI

On 22.09.26 16:04, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 2026-09-22 Tu 3:10 AM, Peter Eisentraut wrote:
>>> One surprise from this is that this generates a massive pgindent diff
>>> against the current tree, because there are a bunch of entries missing
>>> or wrong in src/tools/pgindent/exclude_file_patterns.  I guess most
>>> people don't see this because these are mostly generated files, which
>>> would get reindented but then ignored via gitignore, but if you run
>>> pgindent --check --diff, then this will show up.
>
>> [koel] just runs:
>>    src/tools/pgindent/pgindent --diff --check .
>> Of course, that's against a pure source tree.
>
> Yeah, I generally run pgindent against a clean tree as well. We have
> made some efforts to make generated files be pgindent-clean, but
> it's been pretty haphazard, and I doubt we want to make a project
> policy requiring that. So really the right thing is to make this
> CI module do likewise.

For clarification: We already have a exclude_file_patterns that
excludes many generated files. It just didn't exclude enough of them.
Things were just forgotten. So this proposal is not introducing a new
policy or requirement, it just fixes things so that the implementation
of the current apparent policy is complete.

We could also desupport running pgindent in a tree with both sources and
built files. But then we should do that explicitly and remove the
leftover support for that. However, I wouldn't be in favor of that
unless we desupported in-tree (non-vpath) builds altogether. In any
case, a patch to complete the exclude_file_patterns list for the time
being does exist, so this does not have to be decided urgently.