Re: run pgindent in CI

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: run pgindent in CI
Date: 2026-09-23 14:35:49
Message-ID: 1285147.1790174149@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> For clarification: We already have a exclude_file_patterns that
> excludes many generated files. It just didn't exclude enough of them.
> Things were just forgotten. So this proposal is not introducing a new
> policy or requirement, it just fixes things so that the implementation
> of the current apparent policy is complete.

My point is exactly that that list hasn't been maintained, because
there was nothing to remind developers to do so. So I'm doubtful
that there can meaningfully be claimed to be a policy requiring it.

If we want to change that, then making CI bitch about non-ignored
files would be a good step, but it's incomplete unless the buildfarm
implementation enforces indent cleanliness the same way. IOW, what
I'm complaining about here is that what you want to do doesn't match
what koel does. They need to match.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2026-09-23 14:41:36 Re: Speed up lpad() and rpad() for one-byte padding strings
Previous Message Salma El-Sayed 2026-09-23 14:22:08 Re: [GSoC 2026] - B-tree Index Bloat Reduction - Approach & Questions