| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: run pgindent in CI |
| Date: | 2026-09-23 12:57:03 |
| Message-ID: | CAN55FZ1PqQakh702CLDrQxVi+HZW-GZWVrJ6r3ONwak92y5dgg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, 22 Sept 2026 at 10:11, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> Previously discussed in [0]. People seemed to generally like the idea
> of running pgindent in CI but didn't want the job to fail outright if
> there were violations. My proposal here is to use a combination of
> GitHub Actions features [1] to create job annotations and step summaries
> to create some kind of warning output. I have attached an example
> screenshot.
>
> I also added a git whitespace check in the same way. Additional
> formatting checks like pgperltidy, Python stuff, etc. could be added
> similarly.
>
> Thoughts?
For the 0003, what do you think about just mentioning that 'the
style-check steps in the CompilerWarnings have failed' instead of
printing the diff? That would make sense since we won't actually need
to understand the diff (AFAIK), we just need to run some tools.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-09-23 12:57:09 | Re: run pgindent in CI |
| Previous Message | Peter Eisentraut | 2026-09-23 12:55:10 | Re: run pgindent in CI |