Re: Add table access method as an option to pgbench

From: David Zhang <david(dot)zhang(at)highgo(dot)ca>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add table access method as an option to pgbench
Date: 2020-11-25 20:13:55
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Thank a lot for your comments, Michael.

On 2020-11-24 7:41 p.m., Michael Paquier wrote:
> On Tue, Nov 24, 2020 at 03:32:38PM -0800, David Zhang wrote:
>> But, providing another option for the end user may not be a bad idea, and it
>> might make the tests easier at some points.
> My first thought is that we have no need to complicate pgbench with
> this option because there is a GUC able to do that, but we do that for
> tablespaces, so... No objections from here.
>> The attached file is quick patch for this.
>> Thoughts?
> This patch does not apply on HEAD, where you can just use
> appendPQExpBuffer() to append the new clause to the CREATE TABLE
> query. This needs proper documentation.
The previous patch was based on branch "REL_13_STABLE". Now, the
attached new patch v2 is based on master branch. I followed the new code
structure using appendPQExpBuffer to append the new clause "using
TABLEAM" in a proper position and tested. In the meantime, I also
updated the pgbench.sqml file to reflect the changes.
> --
> Michael

Software Engineer
Highgo Software Inc. (Canada)

Attachment Content-Type Size
v2-0001-add-table-access-method-option-to-pgbench.patch text/plain 3.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2020-11-25 20:37:29 Re: enable_incremental_sort changes query behavior
Previous Message Tomas Vondra 2020-11-25 20:04:51 Re: POC: postgres_fdw insert batching