|From:||Arne Roland <A(dot)Roland(at)index(dot)de>|
|To:||Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>|
|Cc:||vignesh C <vignesh21(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: Rename of triggers for partitioned tables|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Sent: Tuesday, July 20, 2021 02:03
To: Arne Roland
Cc: vignesh C; Zhihong Yu; Pg Hackers
Subject: Re: Rename of triggers for partitioned tables
I found this coding too convoluted, so I rewrote it in a different way.
You tests pass with this, but I admit I haven't double-checked them yet;
I'll do that next.
Is your patch based on master? It doesn't apply at my end.
I don't think we need to give a NOTICE when the trigger name does not
match; it doesn't really matter that the trigger was named differently
before the command, does it?
I'd expect the command
ALTER TRIGGER name ON table_name RENAME TO new_name;
to rename a trigger named "name". We are referring the trigger via it's name after all. If a child is named differently we break with that assumption. I think informing the user about that, is very valuable.
|Next Message||Tom Lane||2021-07-20 00:26:27||Re: O_DIRECT on macOS|
|Previous Message||Greg Nancarrow||2021-07-20 00:12:02||Re: row filtering for logical replication|