| From: | Arne Roland <A(dot)Roland(at)index(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Rename of triggers for partitioned tables |
| Date: | 2021-07-20 00:51:32 |
| Message-ID: | d969d76ba62749699973a12499f944eb@index.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> We are referring the trigger via it's name after all. If a child is named differently we break with that assumption. I think informing the user about that, is very valuable.
To elaborate on that:
While we to similar things for things like set schema, here it has a functional relevance.
ALTER TRIGGER a5 ON table_name RENAME TO a9;
suggests that the trigger is now fired later from now on. Which obviously might not be the case, if one of the child triggers have had a different name.
I like your naming suggestions. I'm looking forward to test this patch when it applies at my end!
Regards
Arne
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-07-20 01:08:56 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | houzj.fnst@fujitsu.com | 2021-07-20 00:30:14 | RE: row filtering for logical replication |