tests: Don't use the initdb template for older installations

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Subject: tests: Don't use the initdb template for older installations
Date: 2026-10-30 19:18:29
Message-ID: xhzif5hemvslxymzhk3ykdypwqvjm7pz5dm7taizgxgfjw6fwa@6gygmz5bdnc3
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

The attached patch fixes the issue that the initdb template mechanism is used
during ->init(), even install_path => ... was passed to Cluster->new().

Obviously using the template, created for the "current" tree, for an older
install won't normally work.

The only reason this hasn't caused breakage so far is that all the existing
tests that use an older node can't use the template for other reasons (because
they pass arguments to ->init()).

I nonticed this when writing a test that didn't pass anything to ->init()...

Planning to push this soon, don't think there's a reason to hold off.

Greetings,

Andres Freund

Attachment Content-Type Size
v1-0001-tests-Don-t-use-the-initdb-template-for-older-ins.patch text/x-diff 1.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Lukas Fittl 2026-10-30 19:19:51 Re: Fix cumulative WAL statistics double-counting from parallel workers
Previous Message Jeff Davis 2026-10-30 19:13:47 Re: WAL record CRC calculated incorrectly because of underlying buffer modification