| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | shihao zhong <zhong950419(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Greg Burd <greg(at)burd(dot)me>, pgsql-hackers(at)postgresql(dot)org, michael(at)paquier(dot)xyz, thomas(dot)munro(at)gmail(dot)com, exclusion(at)gmail(dot)com, amit(dot)kapila16(at)gmail(dot)com, hlinnaka(at)iki(dot)fi |
| Subject: | Re: WAL record CRC calculated incorrectly because of underlying buffer modification |
| Date: | 2026-10-30 19:13:47 |
| Message-ID: | 99401f6a9cc4f2545a9afcffce68fdf162bba10a.camel@j-davis.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2026-10-29 at 22:51 -0400, shihao zhong wrote:
> I agree with that, but I think there are still a decent number of
> users
> who are using hash indexes for different reasons.
...
> Looks like this is an interesting problem. I do agree that if there
> is
> any potential optimization for btree, we should take it all. If
> nobody
> volunteers, I can create a different thread and create a POC for it
> after 19 GAed.
Yes, that makes sense to me. If you think there's benefit to be had,
please go ahead in a new thread.
>
> I am not sure. I know some types' = has special logic, where it may
> not
> mean they are the same.
>
> For example, 'ABC' = 'abc' is true
> with a case-insensitive collation. But md5() gives different results.
Right, there are a few details to work out. But I do think there's room
to solve this in the optimizer rather than add more special cases to
index DDL and the AMs.
We could start by saying it only works if f() is part of a hash
opclass, or something.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Prashant Chinnam | 2026-10-30 18:41:08 | Re: [PATCH] pgcrypto: Fix sha-crypt rounds= values that do not fit in int (BUG #19743) |