Re: C11 / VS 2019

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: C11 / VS 2019
Date: 2025-08-18 13:27:20
Message-ID: vm3bg6brdnr55acely45hchvpgpbxad3755tsyfcuaud4lhfrd@x7toglsdghfx
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2025-07-18 14:12:34 +0300, Peter Eisentraut wrote:
> I also moved the test a bit earlier in meson.build, as a separate patch,
> because between the place where the compiler is first set up and the place
> where we detected the C99 options, if any, there were already some tests run
> that use the compiler. I don't think this was a big problem in practice,
> but it seems a bit incorrect, so it makes sense to correct it.

I distinctly dislike this. You mashed a compiler test in the middle of
something else, without updating any comments. We now do one compiler test
earlier, then dependency tests, and then other compiler tests. Doing anything
the order we do it in autoconf is an anti-argument, because the ordering we
use in autoconf is completely unintelligible.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message torikoshia 2025-08-18 13:32:09 Re: Enhancing Memory Context Statistics Reporting
Previous Message Kirill Reshke 2025-08-18 13:15:05 Re: Sequence Access Methods, round two