From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Sequence Access Methods, round two |
Date: | 2025-08-18 13:15:05 |
Message-ID: | CALdSSPh4eEcR3xmMNdPRtaYYdVx+8UDo8uaub19PVZM4+vEvog@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 18 Aug 2025 at 09:49, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> We could just
> reuse AlterColumn, saving from the extra sub-command. What do you
> think?
Yes, this resonates with me better.
> Rebased the rest as attached, for now.
I have a small enhancement to the patch set.
In v17-0003:
```
reshke(at)yezzey-cbdb-bench:~/cpg$ git diff
diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 8ac13b26fe6..84b7f55fd73 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -3365,7 +3365,7 @@ match_previous_words(int pattern_id,
COMPLETE_WITH("TYPE");
/* Complete "CREATE ACCESS METHOD <name> TYPE" */
else if (Matches("CREATE", "ACCESS", "METHOD", MatchAny, "TYPE"))
- COMPLETE_WITH("INDEX", "TABLE");
+ COMPLETE_WITH("INDEX", "TABLE", "SEQUENCE");
/* Complete "CREATE ACCESS METHOD <name> TYPE <type>" */
else if (Matches("CREATE", "ACCESS", "METHOD", MatchAny,
"TYPE", MatchAny))
COMPLETE_WITH("HANDLER");
```
--
Best regards,
Kirill Reshke
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2025-08-18 13:27:20 | Re: C11 / VS 2019 |
Previous Message | Amit Kapila | 2025-08-18 12:40:35 | Re: Conflict detection for update_deleted in logical replication |