Re: Addition of %b/backend_type in log_line_prefix of TAP test logs

Hi,

On 2025-05-24 09:09:36 +0900, Michael Paquier wrote:
> On Fri, May 23, 2025 at 11:56:59PM +0900, Fujii Masao wrote:
> > On 2025/05/22 8:58, Tom Lane wrote:
> >> Michael Paquier <michael(at)paquier(dot)xyz> writes:
> >>> Another point perhaps worth considering after a second look: how about
> >>> pg_ci_base.conf? We have the following line there, exposing this
> >>> configuration with TEMP_CONFIG:
> >>> src/tools/ci/pg_ci_base.conf:log_line_prefix = '%m [%p][%b] %q[%a][%v:%x] '
> >>
> >>> The two other ones are:
> >>> src/test/perl/PostgreSQL/Test/Cluster.pm: '%m [%p] %q%a '
> >>> src/test/regress/pg_regress.c: '%m %b[%p] %q%a '
> >>
> >>> Perhaps it would be better to apply the same configuration as the CI
> >>> by default at the end?
> >>
> >> I'd vote for standardizing on pg_regress.c's spelling, as that's got
> >> the most usage history behind it. I'm unexcited about bloating the
> >> logs with [%v:%x] --- that's data I've very seldom needed.
> >
> > +1
>
> The %v:%x business in log_line_prefix has been introduced in
> 93d973494613 by Andres. Adding him in CC for comments about the CI
> part.

I'm fine with that.

I'm not a huge fan of "%b" instead of "[%b]", but it doesn't matter much.

Greetings,

Andres Freund