| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Antonin Houska <ah(at)cybertec(dot)at> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Subject: | Re: AIO v2.5 |
| Date: | 2025-06-30 14:44:25 |
| Message-ID: | skjwlhm2nroxr3rk7mnnen36cx3c6ybz4wjr4rslctrdvhirjl@a2kz4qyer327 |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2025-06-30 08:58:21 +0200, Antonin Houska wrote:
> Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> > On 2025-03-13 11:53:03 +0100, Antonin Houska wrote:
> > > Attached are a few proposals for minor comment fixes.
> >
> > Thanks, applied.
>
> After reading the code a bit more, I noticed that the 'cb_flags' argument of
> PgAioHandleCallbackStage is not really used, at least in the existing
> callbacks. Is there an intention to use it in the future (the patches for
> async write do not seem to indicate so), or is this only a leftover from
> previous versions of the patch?
Thanks for reading through it!
It seemed more symmetric to have it for stage as well as the completion
callback - and I still think that...
> Besides that, I suggest a minor comment fix.
Thanks. Pushed that fix.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-06-30 14:45:00 | Re: [PATCH] Fix OAuth feature detection on OpenBSD+Meson |
| Previous Message | Maxim Orlov | 2025-06-30 14:39:06 | Re: Add 64-bit XIDs into PostgreSQL 15 |