| From: | Antonin Houska <ah(at)cybertec(dot)at> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Subject: | Re: AIO v2.5 |
| Date: | 2025-06-30 06:58:21 |
| Message-ID: | 5250.1751266701@localhost |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2025-03-13 11:53:03 +0100, Antonin Houska wrote:
> > Attached are a few proposals for minor comment fixes.
>
> Thanks, applied.
After reading the code a bit more, I noticed that the 'cb_flags' argument of
PgAioHandleCallbackStage is not really used, at least in the existing
callbacks. Is there an intention to use it in the future (the patches for
async write do not seem to indicate so), or is this only a leftover from
previous versions of the patch?
Besides that, I suggest a minor comment fix.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
| Attachment | Content-Type | Size |
|---|---|---|
| comment.diff | text/x-diff | 482 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2025-06-30 06:58:25 | Re: Skipping schema changes in publication |
| Previous Message | shveta malik | 2025-06-30 06:51:44 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |