Re: Remove unused arguments from split_selfjoin_quals()

From: Miłosz Bieniek <bieniek(dot)milosz(at)proton(dot)me>
To: Tender Wang <tndrwang(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Subject: Re: Remove unused arguments from split_selfjoin_quals()
Date: 2026-08-27 10:21:53
Message-ID: rr_tZFmrHAsjeLVrghD8nwsBaCQKUanky8vGgStFQWSsx656zlwIVjpFpmJNCXoqh5W0TyIuFS-aUi2gl00ZCkH7w_IufB9PtwTvocjqNV4=@proton.me
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Tender

I think `root` argument was introduced in [1] to do an assertion,
but that assertion was removed shortly after being added.
`from` and `to` on the other hand were introduced in [2],
but weren't used from the start.

LGTM!

[1] https://www.postgresql.org/message-id/CAKJS1f8cJOCGyoxi7a_LG7eu%2BWKF9%2BHTff3wp1KKS5gcUg2Qfg%40mail.gmail.com
[2] https://www.postgresql.org/message-id/c97574c4-13e6-9107-26ab-af2bd626fc85%40postgrespro.ru

Kind regards,
Miłosz Bieniek

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Florin Irion 2026-08-27 10:25:22 Re: Proposal: Supporting URI SAN in Certificate Authentication
Previous Message Nikhil Sontakke 2026-08-27 09:45:18 Re: [PATCH] Fix JSON_SERIALIZE() coercion placeholder type for jsonb input