| From: | Tender Wang <tndrwang(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Remove unused arguments from split_selfjoin_quals() |
| Date: | 2026-08-19 06:40:28 |
| Message-ID: | CAHewXNmwCFH5bk0ANX8wRG8Y_4c9jh8OTKceNM1W6ijDS3DzLA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
While reviewing a patch for a self-join elimination bug, I noticed that
split_selfjoin_quals() takes "from" and "to" arguments. These names also
seemed a little inconsistent with the "remove" and "keep" terminology
used by the surrounding SJE code.
Looking further, I found that neither of these arguments is actually
used by the function. The "root" argument is unused as well. I also
checked the history and found that these arguments have been unused
since the SJE code was initially committed.
The attached patch removes these three unused arguments and simplifies
the function interface. There is no functional change.
--
Thanks,
Tender Wang
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-unused-arguments-from-split_selfjoin_quals.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anthonin Bonnefoy | 2026-08-19 06:50:40 | Re: Fix small psql slash option leaks |
| Previous Message | Masahiko Sawada | 2026-08-19 06:25:00 | Re: [PATCH] Fix NULL dereference in subscription REFRESH on concurrent DROP |