| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image |
| Date: | 2010-04-29 19:40:42 |
| Message-ID: | p2w937d27e11004291240tfc01ca6csc3d646a8886174f4@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Thu, Apr 29, 2010 at 2:25 PM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Dave,
> As discussed, I am not confident about the Printing support on Mac OSX.
> It is working well on other platforms. In fact, Print Preview is also
> working good on OSX. But, It gives arbitrary results for the printing.. (The
> main feature of this patch.) :-(
> I will need some more time investigating the exact issue.
> As discussed, I m taking of the save as an image functionality from the
> patch and sending you the patch for the same with this.
> I am feeling very disappointed, but I do not want to rush into the things
> and do not want to do things in hurry.
Yeah, it's annoying but the right thing to do.
I've committed the patch as it is now, but please work on the
following fixes for the next beta:
- Only enable the Save Image menu options if there is something to
save. Accidently clicking the wrong one currently gives an annoying
'Nothing to save' message.
- Remember the file format selected by the user and use that as the
default the next time.
- Remember the last filename independently for the GQB and EXPLAIN output files.
Thanks!
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company