Re: Wrap access to Oid in HeapTupleHeader

From: Manfred Koizar <mkoi-pg(at)aon(dot)at>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Wrap access to Oid in HeapTupleHeader
Date: 2002-07-03 19:37:00
Message-ID: m6j6iu00hslcppammsfkt8585dld3br8qf@4ax.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Wed, 03 Jul 2002 13:50:45 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
wrote:
>> Where should DEBUG_TUPLE_ACCESS be defined or undef'd?
>
>It doesn't need to be anywhere, but you could add it to pg_config.h.in
>near line 308, where there are other similar symbols, eg
> /* #define ACLDEBUG */

Ok, initially I'll define it there so that all the fellow hackers can
help debug my patches ;-)

>To do the same in your proposed change, those
>places will need more knowledge. They can't just blindly fetch from
>tuple + t_hoff - sizeof(Oid).

Yes, that's why I have planned some intermediate steps before finally
switching to the new format. As you have guessed by now I'm not a
friend of huge "do it all at once" patches. I prefer to do a number
of small steps. This first patch does not break the code and takes us
one step in the right direction. More patches will follow.

As nobody else commented, it seems that it depends on your approval,
before a revised version of the patch will be applied.

Servus
Manfred

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Christopher Kings-Lynne 2002-07-04 02:11:36 Adding attisdropped
Previous Message Jie Liang 2002-07-03 19:03:27 Re: pg_restore cannot restore function