Re: patch: to_string, to_array functions

From: Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Brendan Jurd <direvus(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Merlin Moncure <mmoncure(at)gmail(dot)com>
Subject: Re: patch: to_string, to_array functions
Date: 2010-07-23 18:34:19
Message-ID: m2hbjqrqs4.fsf@hi-media.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>>> so my preferences:
>>>>
>>>> 1. split, join - I checked - we are able to create "join" function
>>>> 2. split, array_join - when only "join" can be a problem
>>>> 3. string_split, array_join - there are not clean symmetry, but it
>>>> respect wide used a semantics - string.split, array.join
>>>> 4. explode, implode
>>>> 5. array_explode, array_implode
>>>> -- I cannot to like array_split - it is contradiction for me.
>
> Yeah, I'd like some more votes, too.

I still don't see a compelling reason not to extend existing functions
with a third argument. Or are we talking about deprecating them in the
future (like remove their mention in the docs) and have the new names to
replace them, with the new behavior as the default and the extended call
convention as the old behavior?

I'm not sure about that, so I think extending existing function is ok.

Or we would have to have the new functions work well with other types
too, so that it's compelling to move from the old ones.

Regards,
--
dim

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-07-23 18:34:28 Re: patch: Add JSON datatype to PostgreSQL (GSoC, WIP)
Previous Message Marko Tiikkaja 2010-07-23 18:13:18 Re: Rewrite, normal execution vs. EXPLAIN ANALYZE