Re: [9.1] 2 bugs with extensions

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Marko Kreen <markokr(at)gmail(dot)com>
Cc: Postgres Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [9.1] 2 bugs with extensions
Date: 2012-09-28 19:25:14
Message-ID: m2bogqymp1.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Marko Kreen <markokr(at)gmail(dot)com> writes:
> Indeed, after another makefile reorg, I could not reproduce it
> on skytools master either, some digging showed that due
> to a makefile bug ($< instead $^) the ADD SCHEMA
> was missing from .sql file. So no bug in postgres.

That would explain, indeed :)

> Could you test if Skytools git now works for you?

It does:

dim ~/dev/skytools/sql/pgq_coop make pgq_coop--unpackaged--3.1.1.sql
../../scripts/catsql.py structure/upgrade.sql > pgq_coop.upgrade.sql
../../scripts/catsql.py pgq_coop.upgrade.sql structure/ext_unpackaged.sql structure/ext_postproc.sql > pgq_coop--unpackaged--3.1.1.sql
dim ~/dev/skytools/sql/pgq_coop make pgq_coop--3.1.1.sql
../../scripts/catsql.py structure/install.sql > pgq_coop.sql
../../scripts/catsql.py pgq_coop.sql structure/ext_postproc.sql >
pgq_coop--3.1.1.sql

> I replaced sed usage with awk there, perhaps that will be
> more portable.

I seem to recall needing to explicitly use `gawk` for some scripts,
depending on the features you want to have. Some systems default awk are
`mawk` or even some really old versions and don't have much features…

That said, it seems to work here, now. Thanks!

Regards,
--
Dimitri Fontaine 06 63 07 10 78
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-09-28 19:45:40 Re: Patch: incorrect array offset in backend replication tar header
Previous Message Fujii Masao 2012-09-28 19:09:53 Re: XLogInsert scaling, revisited