| From: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Event Triggers reduced, v1 |
| Date: | 2012-06-29 21:38:15 |
| Message-ID: | m2a9zlkddk.fsf@2ndQuadrant.fr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> ../../../src/include/catalog/pg_event_trigger.h:34: error: expected
> specifier-qualifier-list before ‘int2’
>
> This needs to be changed to int16 as a result of commit
> b8b2e3b2deeaab19715af063fc009b7c230b2336.
Done as part of the previous work.
> alter.c:73: warning: implicit declaration of function ‘RenameEventTrigger’
Done now.
> Please spell out DO_EVTTRIGGER as DO_EVENT_TRIGGER.
Also done as part of the previous email.
> Another random warning:
> plpy_main.c:195: warning: ‘retval’ may be used uninitialized in this function
Will do a whole warning check pass later. Can you give me your local
Makefile trick to turn them into hard errors again please? :)
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-06-29 22:54:11 | Re: change_varattnos_of_a_node versus whole-row Vars |
| Previous Message | Tom Lane | 2012-06-29 21:35:34 | Re: elog/ereport noreturn decoration |